Hi

I'm looking for the proper way to remove my addin's menu bar from the
OnDisconnect method. I want that when the addin is unloaded via the
Addin manager, that its commands and the menubar on which they sit
disappear. I've got this working on the first pass. But when I reload
the addin the second time, I get multiple copies of my menubar.
Sometimes the menubar has the correct name, sometimes it has a
different name (I think depending on the index of where I insert the
menubar on its parent menubar).

I suspect I'm not removing my menubar correctly. Is there a 'correct'
way to do this?

I have some sample code below that shows my problem. Here I am adding
an "AddinTemplate" Menubar to the "MenuBar->Build" menu. It has 2
commands (FooAddinTemplate, BarAddinTemplate). If I add the addin via
the Manager, it looks good. THen removing it also looks good (my
menubar goes away). On adding it back a 2nd time causes problems; I get
2 versions of my menubar.

Here's the OnConnection and OnDisconnection methods

[code]
public void OnConnection(object application, ext_ConnectMode
connectMode, object addInInst, ref Array custom)
{
 _applicationObject = (DTE2)application;
 _addInInstance = (AddIn)addInInst;
 if(connectMode == ext_ConnectMode.ext_cm_UISetup ||
    connectMode == Extensibility.ext_ConnectMode.ext_cm_Startup ||
    connectMode == Extensibility.ext_ConnectMode.ext_cm_AfterStartup )

 {
   object []contextGUIDS = new object[] { };
   Commands2 commands = (Commands2)_applicationObject.Commands;

   //Place the command on the Build Menu
   Microsoft.VisualStudio.CommandBars.CommandBar menuBarCommandBar =
((Microsoft.VisualStudio.CommandBars.CommandBars)_applicationObject.CommandBars)["MenuBar"];
   CommandBar BuildCommandBar =
((CommandBarPopup)menuBarCommandBar.Controls["Build"]).CommandBar;

   try
   {
     //Add a command to the Commands collection:
     Command foo_command = commands.AddNamedCommand2(_addInInstance,
"FooAddinTemplate", "FooAddinTemplate", "Executes the command for
AddinTemplate", true, 59, ref contextGUIDS,
(int)vsCommandStatus.vsCommandStatusSupported+(int)vsCommandStatus.vsCommandStatusEnabled,
(int)vsCommandStyle.vsCommandStylePictAndText,
vsCommandControlType.vsCommandControlTypeButton);
     Command bar_command = commands.AddNamedCommand2(_addInInstance,
"BarAddinTemplate", "BarAddinTemplate", "Executes the command for
AddinTemplate", true, 59, ref contextGUIDS,
(int)vsCommandStatus.vsCommandStatusSupported +
(int)vsCommandStatus.vsCommandStatusEnabled,
(int)vsCommandStyle.vsCommandStylePictAndText,
vsCommandControlType.vsCommandControlTypeButton);
     CommandBar addinCmdBar =
(CommandBar)commands.AddCommandBar("AddinTemplate",
vsCommandBarType.vsCommandBarTypeMenu, BuildCommandBar,
BuildCommandBar.Controls.Count);
     CommandBarControl addinFooControl =
(Microsoft.VisualStudio.CommandBars.CommandBarControl)foo_command.AddControl(addinCmdBar,
1);
     CommandBarControl addinBarControl =
(Microsoft.VisualStudio.CommandBars.CommandBarControl)bar_command.AddControl(addinCmdBar,
2);
   }
   catch(System.ArgumentException)
   { ; }
 }
}

public void OnDisconnection(ext_DisconnectMode disconnectMode, ref
Array custom)
{
 if (disconnectMode != ext_DisconnectMode.ext_dm_UserClosed &&
     disconnectMode != ext_DisconnectMode.ext_dm_HostShutdown)
   return;

 CommandBar cmdBar;
 try
 {
   while ((cmdBar =
((Microsoft.VisualStudio.CommandBars.CommandBars)this._applicationObject.CommandBars)["AddinTemplate"])
!= null)
   {
     foreach (CommandBarControl objCBC in cmdBar.Controls)
     {
       try
       {
         objCBC.Delete(null);
       }
       catch (System.Exception e)
       {; }
     }

     try
     {
       this._applicationObject.Commands.RemoveCommandBar(cmdBar);
     }
     catch (System.Exception e)
     { ; }
   }
 }
 catch { ; }

 // Remove all Commands
 Command cmd = null;
 try
 {
   cmd =
this._applicationObject.Commands.Item("AddinTemplate.Connect.FooAddinTemplate",
-1);
   cmd.Delete();
   cmd =
this._applicationObject.Commands.Item("AddinTemplate.Connect.BarAddinTemplate",
-1);
   cmd.Delete();
 }
 catch { ; }
}

[/code]