Well, Ben was right. His aproach is the correct way to compare strings. If you
use my aproach you're comparing objects. The question is: Why my aproach works
sometimes? It works because internally the form and S prefixed strings use the
same MSIL instruction to load strings from meatada, ldstr. The documentation for
ldstr says:

"...The Common Language Infrastructure (CLI) guarantees that the result of two
ldstr instructions referring to two metadata tokens that have the same sequence
of characters return precisely the same string object (a process known as
"string interning")..."

So, in the case of

    if (button1->Text == S"Start")

We're comparing the same String object.
Why sometimes fails? Because the next time you change the text with:

    button1->Text = "Start";

you're not going to use a string loaded from metadata with ldstr. Internally
"Start" is trated like an array of char (data isn't stored in the metada
section). When you assign the string, a new String object is created, so the
next comparisson will fail (because, you're going to compare two distinct
objects).

If you assign prefixed strings, the code will work too:

   if (button1->Text == S"Start")
   {
        button1->Text = S"Stop";
    }
    else
    {
        button1->Text = S"Start";
    }

Regards

--
Cholo Lennon
Bs.As.
ARG