Home | Contact Us | FAQ | Search & Site Map | Link to Us
Sign In | Join | Other 45 Sites in Network
HomeAnnouncementsFree MagazinesWhite PapersSubmit Content
Discussion GroupsASP.NETWindows FormsLanguages.NET FrameworkVisual Studio.NET
Articles.NET FrameworkASP.NETToolsWindows Forms
.NET DirectoryOpen Source ProjectsUser GroupsWeb Resources
Related Topics
Visual Basic 6SQL ServerMS AccessOther DB ProductsMS Server ProductsMore Topics ...

.NET Forum / ASP.NET / Security / August 2003

Tip: Looking for answers? Try searching our database.

Secure Database-Driven output to Web-Controls like Repeater

Thread view: 
Enable EMail Alerts  Start New Thread
Thread rating: 
ViperDK \(Daniel K.\) - 13 Aug 2003 16:12 GMT
scenario: users can store data (guestbook entries, ther usernames and so on)
on a database-driven website and i have to care about that they don't insert
(aggressive) javascripts or html tags that destroy my layout. but it's not
an option to deny characters like ', " or < at all.

one option i got suggested is to make all the input to valid html output (Do
a HtmlEncode) before i store it in the database but i think that is not that
great because its to limited and bad design. if i make an winform
application or something else that is not web-based i'd have to handle and
undo all the html stuff that is only useful for html pages.

the two right solutions for this that i think of is to code controls like
Repeater with an property like "UseRawHtmlData" and let it automatically
HtmlEncode all output unless it  is set for RawHtmlData. That would be a
safe design i think but it has the disadvantage that ms didn't do it and i'd
have to make many modified controls that do.
the other solution i think of is to code an SqlDataReader and a
SqlDataAdapter that also automatically HtmlEncode all text data.

I think the second way makes more sense - i would only have to use that
modified sql classes and i would not have to touch the data-webcontrols like
repeater, datagrid and so on.

does anyone have such classes to use instead of the normal Sql classes or is
there a better alternative to solve that problem. to HtmlEncode every field
manually like i do now seems to be the worst answer since it makes much work
and is error prone.
Eric Newton - 15 Aug 2003 19:54 GMT
Well, before I can offer a solution I need a few pointers:

- are you intending to store the actual html in the database?
- you said you dont care about JS/HTML that can destroy layout, which makes
things easier

unless I'm mistaken I dont believe the "BoundColumns" in DataGrids change
the valid HTML to be Encoded HTML,
and since the repeater utilizes templates, then you are in better control.

In your repeater template, are you using "<asp:label runat=server text='<%#
DataBinder.Eval... %>'>"? if so then the Text property is automatically HTML
encoded, trying changing to using the HtmlControls, specifically the
HtmlGenericControl and setting the InnerHtml property, whereas this property
takes a string and outputs it verbatim.

HTH

Signature

Eric Newton
eric@ensoft-software.com
C#/ASP.net Solutions developer

> scenario: users can store data (guestbook entries, ther usernames and so on)
> on a database-driven website and i have to care about that they don't insert
[quoted text clipped - 23 lines]
> manually like i do now seems to be the worst answer since it makes much work
> and is error prone.
ViperDK \(Daniel K.\) - 16 Aug 2003 02:45 GMT
no i want to store all data as it is. if someone writes stuff like "i like
<i> tags" it should get 1:1 into the database and i want an easy way to
verify in the output that it does get encoded.

i usually use DataGrids with BoundColumns like
<asp:BoundColumn DataField="Comment" HeaderText="Comment"></asp:BoundColumn>

and yes i saw that the HtmlGenericControl has a property for the encodet and
the raw content. i wonder why the the TextBox WebControl hasn't that
functionality. thought they should be first choice.

> Well, before I can offer a solution I need a few pointers:
>
[quoted text clipped - 18 lines]
> eric@ensoft-software.com
> C#/ASP.net Solutions developer
Eric Newton - 22 Aug 2003 08:37 GMT
Yeah, I guess the textboxes were designed from the start to be HTML proper,
ie, if they have HTML in their text property then its HTMLEncoded so that
what is in the text is exactly what you see...

I would guess it'll always stay this way, but a simple boolean property
wouldnt hurt ;-)

Signature

Eric Newton
eric@ensoft-software.com
C#/ASP.net Solutions developer

> no i want to store all data as it is. if someone writes stuff like "i like
> <i> tags" it should get 1:1 into the database and i want an easy way to
[quoted text clipped - 33 lines]
> > eric@ensoft-software.com
> > C#/ASP.net Solutions developer

Free Magazines

Get these publications absolutely FREE for up to 12 months. There are no hidden fees and no obligation. Simply choose a title, complete the application form and submit it. Read more ...

Oracle MagazineNetwork ComputingComputer WorldBio-IT WorldeWeekInformation WeekInfosecurity
 
Sign In
Join
My Latest Posts
My Monitored Threads
My Blog
My Photo Gallery
My Profile
My Homepage

Start New Thread
Enable EMail Alerts
Rate this Thread



©2008 Advenet LLC   Privacy Policy - Terms of Use
This website includes both content owned or controlled by Advenet as well as content owned or controlled by third parties.